Review Request: Add option to control PAM support

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103818/#review10198
-----------------------------------------------------------


The change in FindPAM.cmake is wrong.
FindPAM.cmake does not care whether WITH_PAM is TRUE or not, when called, it will search PAM.
If WITH_PAM is disabled, FindPAM.cmake will not be executed, and additionally all PAM_* variables will be set to empty.
It should work without the change in FindPAM.cmake.

- Alexander Neundorf


On Jan. 29, 2012, 10:35 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103818/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 10:35 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> kcheckpass and KDM support being built without PAM, but this selection is currently automagic.
> 
> This patch adds a WITH_PAM option, and makes sure that the patched cmake modules are preferred over the system ones.
> 
> 
> Diffs
> -----
> 
>   ConfigureChecks.cmake fe06d9e 
>   cmake/modules/FindPAM.cmake 3499836 
>   cmake/modules/UnixAuth.cmake 904f0cb 
> 
> Diff: http://git.reviewboard.kde.org/r/103818/diff/diff
> 
> 
> Testing
> -------
> 
> For me, both kcheckpass and KDM link against libcrypt instead of PAM and work fine when -DWITH_PAM=no is specified.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120129/a87f5692/attachment.htm>