Review Request: Record job dbus id in dataengine to allow software to terminate a job through DBUS

[Shaun Reich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103732/#review9952
-----------------------------------------------------------


hi, thanks for the patch.

however, i'm not sure i understand the issue it is addressing.

the applicationjobs plasma dataengine isn't meant to have an extensive dbus interface at all really. that's kuiserver's job, as it's the actual host of it.

additionally, since the applicationjobs::JobView implements the org.kde.JobViewV2 interface, and methods like ::terminate already exist, that gives us bidirectional communication automatically. (you can test this by...when some long job is running, go to qdbusviewer, org.kde.plasma-desktop, DataEngine/applicationjobs/JobView_%1/org.kde.JobViewV2...and you will see all the methods implemented anyways, and the calls of those methods are propagated upwards to kuiserver).

- Shaun Reich


On Jan. 19, 2012, 7:55 a.m., Bellegarde Cédric wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103732/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2012, 7:55 a.m.)
> 
> 
> Review request for KDE Base Apps and kdelibs.
> 
> 
> Description
> -------
> 
> Record job dbus id in Plasma::DataEngine object.
> 
> This will give a simple way to do things like this:
> 
> 
>             QString path = "/JobViewServer/JobView_" + QString(data["jobDbusId"]);
>             QDBusMessage m = QDBusMessage::createMethodCall(
>                                    "org.kde.JobViewServer",
>                                    path,
>                                    "org.kde.JobViewV2",
>                                    "terminate");
>             bus.call(m);
> 
> when you want to terminate a job.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/applicationjobs/kuiserverengine.cpp 59a4de7 
> 
> Diff: http://git.reviewboard.kde.org/r/103732/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bellegarde Cédric
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120119/b230c623/attachment.htm>