Review Request: Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103730/#review9929
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks fine!

- Peter Penz


On Jan. 18, 2012, 7:03 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103730/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 7:03 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> The attached patch fixes a logic error in the code that determines which remote encoding should be checked when the "Show Remote Encoding" menu is shown. The logic flaw only affects when the user chooses an encoding which has similar types, e.g. ISO-8859-1*.
> 
> 
> This addresses bug 186289.
>     http://bugs.kde.org/show_bug.cgi?id=186289
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinremoteencoding.cpp 8644f5c 
> 
> Diff: http://git.reviewboard.kde.org/r/103730/diff/diff
> 
> 
> Testing
> -------
> 
> 1.) Connect to a remote server.
> 2.) Change the remote charset encoding to "Western European ( ISO-8859-1 )".
> 3.) Go back to the remote encoding and check what is selected.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120118/beba30fc/attachment.htm>