Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

[Dirk Tilger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103593/#review9870
-----------------------------------------------------------


While it definitely makes sense to make the KDE logout work, isn't the root of the problem that KNotification doesn't call the slot if no sound is available? Other applications would be affected by this very issue, if they are triggering sounds the same way. In my opinion it'd make more sense to fix KNotification to issue a ignore() slot call when no sound is available.
It wouldn't hurt, of course, to fix it in both places. ;)

- Dirk Tilger


On Dec. 31, 2011, 3:16 a.m., Peter OGorman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103593/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2011, 3:16 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=228005
> if sound is not working for some reason (e.g. no phonon
> backends are installed) the closed() signal never happens
> and logoutSoundFinished() never gets called. This hack
> makes sure that logout still occurs. Of course, on systems
> with working sound there's a race.
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdown.cpp 7fd1e11 
> 
> Diff: http://git.reviewboard.kde.org/r/103593/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter OGorman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120116/50c9135f/attachment.htm>