Review Request: fix the rect passed to kcapacitybar paint method
Thomas Lübking
thomas.luebking at web.de
Fri Jan 13 15:50:10 GMT 2012
> On Jan. 13, 2012, 3:49 p.m., Thomas Lübking wrote:
> > Ship It!
I'm not the maintainer of kcapacitybar, solid or dolphin, but the patch is correct, fixes a bug and should enter 4.8.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103669/#review9803
-----------------------------------------------------------
On Jan. 12, 2012, 7:06 p.m., Hugo Pereira Da Costa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103669/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2012, 7:06 p.m.)
>
>
> Review request for Dolphin, kdelibs and Solid.
>
>
> Description
> -------
>
> fixes the rect passed to paint method so that it matches the widget rect and not the event (clip) rect, since the former is what's expected by widget styles.
>
>
> This addresses bug 290879.
> http://bugs.kde.org/show_bug.cgi?id=290879
>
>
> Diffs
> -----
>
> kdeui/widgets/kcapacitybar.cpp 6e63c3f
>
> Diff: http://git.reviewboard.kde.org/r/103669/diff/diff
>
>
> Testing
> -------
>
> Fixes bug above.
> No regression with other styles.
>
>
> Thanks,
>
> Hugo Pereira Da Costa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120113/aaf4407c/attachment.htm>
More information about the kde-core-devel
mailing list