Review Request: fix the rect passed to kcapacitybar paint method

Thomas Lübking thomas.luebking at web.de
Tue Jan 10 18:08:21 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103669/#review9716
-----------------------------------------------------------



kdeui/widgets/kcapacitybar.cpp
<http://git.reviewboard.kde.org/r/103669/#comment8029>

    rather "..., contentsRect());"
    Otherwise looks fine (i guess setCllipRegion() is overhead)


- Thomas Lübking


On Jan. 10, 2012, 5:06 p.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103669/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 5:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> fixes the rect passed to paint method so that it matches the widget rect and not the event (clip) rect, since the former is what's expected by widget styles.
> 
> 
> This addresses bug 290879.
>     http://bugs.kde.org/show_bug.cgi?id=290879
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kcapacitybar.cpp 6e63c3f 
> 
> Diff: http://git.reviewboard.kde.org/r/103669/diff/diff
> 
> 
> Testing
> -------
> 
> Fixes bug above.
> No regression with other styles.
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120110/4278c1c1/attachment.htm>


More information about the kde-core-devel mailing list