Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

[Lamarque Vieira Souza]

> On Jan. 4, 2012, 10:22 p.m., Lamarque Vieira Souza wrote:
> > ksmserver/shutdown.cpp, line 469
> > <http://git.reviewboard.kde.org/r/103593/diff/1/?file=45171#file45171line469>
> >
> >     As long as ksmserver is not multi-threaded the race will not cause problems because logoutSoundFinished slot returns if state is different from WaitingForKNotify and the last thing logoutSoundFinished slot does is call startKilling, which changes the state. The second logoutSoundFinished signal will test the state in logoutSoundFinished slot and return.

Please update the request header: add a small description in the summary instead of an url. Add the bugs that this patch fixes in the "Bugs" field, add bug numbers only, not the url. Bug #290625 "Shutdown does not work on Meego PA2" is also fixed by this patch.

If nobody comes up with a better solution I vote for shipping this request.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103593/#review9556
-----------------------------------------------------------


On Dec. 31, 2011, 3:16 a.m., Peter OGorman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103593/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2011, 3:16 a.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=228005
> if sound is not working for some reason (e.g. no phonon
> backends are installed) the closed() signal never happens
> and logoutSoundFinished() never gets called. This hack
> makes sure that logout still occurs. Of course, on systems
> with working sound there's a race.
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdown.cpp 7fd1e11 
> 
> Diff: http://git.reviewboard.kde.org/r/103593/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter OGorman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120107/05e4a4a8/attachment.htm>