Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103631/#review9616
-----------------------------------------------------------


We're getting there :-)
...but not yet completely.

You actually don't have to compare the version number yourself, find_package_handle_standard_args() does that for you. It is enough to get a variable which contains the complete version string.
So at least the lines where XINE_VERSION_OK is set to TRUE can be removed.

While at it, please also do the following things:
- setting Xine_FIND_QUIETLY to TRUE is not necessary, please remove this if() completely (find_package_handle_standard_args() is quiet by itself if the output has not changed from the previous run)
- remove the if(WIN32) around the pkgconfig-stuff. People say it should work also on Windows. So let's see.
- is the check_c_source_compiles() stuff actually necessary ? Can it simply be removed ? I'd say so.

- Alexander Neundorf


On Jan. 6, 2012, 1:06 p.m., Johannes Huber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103631/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 1:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This is a gentoo downstream patch, see bug https://bugs.gentoo.org/show_bug.cgi?id=397595 for cause.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindXine.cmake 37c58c6 
> 
> Diff: http://git.reviewboard.kde.org/r/103631/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120106/3111e8fa/attachment.htm>