Review Request: Port shutdown dialog to QML

[Alexander Neundorf]

On Thursday 05 January 2012, Lamarque V. Souza wrote:
> Em Wednesday 04 January 2012, Alexander Neundorf escreveu:
> > On Wednesday 04 January 2012, Lamarque Vieira Souza wrote:
> > > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote:
> > > > > ksmserver/CMakeLists.txt, line 57
> > > > > <http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file453
> > > > > 63 li ne57>
> > > > > 
> > > > >     no variable for kdeclarative?
> > > > 
> > > > Lamarque Vieira Souza wrote:
> > > >     There is one in shutdowndlg.cpp, in KSMShutdownDlg's constructor.
> > > > 
> > > > Albert Astals Cid wrote:
> > > >     I mean cmake variable like ${SOMETHING_SOMETHING}
> > > 
> > > I do not think so. All CMakeLists.txt throughout kde-workspace,
> > > kde-runtime and plasma-mobile add the library name directly.
> > 
> > libkdeclarative is from kdelibs/experimental/, right ?
> 
> 	Yes.
> 
> > So, it is not from within the same project.
> > And I didn't find a place where libkdeclarative would install a
> > KDeclarativeConfig.cmake file. Did I miss this somewhere ?
> > 
> > If not, is there a FindKDeclarative.cmake somewhere ?
> > 
> > If not, this is seriously messed up.
> > 
> > It would mean that simply using "kdeclarative" means that cmake
> > interprets this as name of a library and simply adds -lkdeclarative to
> > the command line, without checking whether it actually exists nor in
> > which directory.
> 
> 	I guest that is indeed what happens now.
> 
> > So, is there a FindKDeclarative.cmake or a KDeclarativeConfig.cmake file
> > somewhere ?
> 
> 	locate /*Declarative*.cmake returned nothing here, so there is none in
> my notebook.

So, quick solution: write a simply FindKDeclarative.cmake file (mostly 
find_library(), find_path() and a find_package_handle_standard_args() call) 
and use this (but don't install it).

Good solution: kdeclarative should install a KDeclarativeConfig.cmake file, so 
it will be found automatically. But this has to be done carefully.

Alex