Review Request: Port shutdown dialog to QML

[Christoph Feck]

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote:
> > Very nice work, one of the things where QML makes sense.
> > 
> > Are there any i18n string regressions? If possible, I would see it in 4.8 (maybe not 4.8.0, but backport sometimes later, after it has received testing in master), but that will only work when translation files do not change.
> 
> Lamarque Vieira Souza wrote:
>     Some strings changed because no QML component supports QLabel's accelerators, for example i18n("&Cancel") became i18n("Cancel").

Oh, that's bad :(

Multiple options:
1) Keep the old strings in C++ code, and pass them as attributes to the QML code with accelerator markers stripped. This means more work for you now, but has the advantages that no translations need to be changed, and that we can even reactivate accelerators later, when QML supports those.

2) Ask i18n team if you could remove them *now* also in branch, so that they don't change later during 4.8 stabilization phase.

3) Apply this patch only to master, and release it starting with KDE 4.9.

Of course I would prefer option 1.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review9521
-----------------------------------------------------------


On Jan. 4, 2012, 5:03 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2012, 5:03 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Runtime.
> 
> 
> Description
> -------
> 
> Port the shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look & fell, and countour, which is used in Plasma Active.
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdowndlg.cpp a09a1a7 
>   ksmserver/shutdowndlg.h e5f0942 
>   ksmserver/shutdown.cpp 7fd1e11 
>   ksmserver/CMakeLists.txt 295b96e 
>   ksmserver/themes/contour/ContourButton.qml PRE-CREATION 
>   ksmserver/themes/contour/main.qml PRE-CREATION 
>   ksmserver/themes/contour/metadata.desktop PRE-CREATION 
>   ksmserver/themes/contour/screenshot.png PRE-CREATION 
>   ksmserver/themes/default/ContextMenu.qml PRE-CREATION 
>   ksmserver/themes/default/KSMButton.qml PRE-CREATION 
>   ksmserver/themes/default/MenuItem.qml PRE-CREATION 
>   ksmserver/themes/default/main.qml PRE-CREATION 
>   ksmserver/themes/default/metadata.desktop PRE-CREATION 
>   ksmserver/themes/default/screenshot.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
> 
> 
> Testing
> -------
> 
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the patch requires kde-runtime 4.8's declarative imports.
> 
> There is still one bug left: keyboard nagivation works with TAB, BACKSPACE, and arrow-keys, but only the TAB key works at first. You always have to press the TAB key at least once for the other keys to work for navigation. The first TAB press only activates the navigation, you still need a second press to actually move focus to the next element.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/103621/s/400/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120104/05189d79/attachment.htm>