Review Request: Port shutdown dialog to QML

[Lamarque Vieira Souza]

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote:
> > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some consistency there would be nice
> > 
> > You need to extract the i18n messages from the qml files
> > 
> > And having the keyboard not working seems like a huge regression for my own usecase ;-)
> 
> Lamarque Vieira Souza wrote:
>     All QtQuick imports in Contour theme are 1.0, all QtQuick imports in default theme are 1.1. Why Contour theme should use 1.1 if it is not required? They are independent implementations.
>     
>     How do I extract i18n messages in qml files? Is there any guide for that?
>     
>     The keyboard works, you just need to press the TAB key once to activate it, then you can use the TAB, SHIFT+TAB and arrow-keys to navigate and ENTER or BAR to "click" the button. I have not figure out why the first TAB is required.
> 
> Christoph Feck wrote:
>     Try Qt::StrongFocus, maybe it forces activation of the view.

It did not work but I have found what I did wrong, or more precisely forgot to do. In the original implementation the focus was on the dialog, but now the focus must go to the QML view. Not it works.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103621/#review9516
-----------------------------------------------------------


On Jan. 3, 2012, 5:34 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103621/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2012, 5:34 p.m.)
> 
> 
> Review request for KDE Base Apps and KDE Runtime.
> 
> 
> Description
> -------
> 
> Port the shutdown dialog to QML. Two QML themes are included: default, which mimics the current shutdown dialog look & fell, and countour, which is used in Plasma Active.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 295b96e 
>   ksmserver/shutdown.cpp 7fd1e11 
>   ksmserver/shutdowndlg.h e5f0942 
>   ksmserver/shutdowndlg.cpp a09a1a7 
>   ksmserver/themes/contour/ContourButton.qml PRE-CREATION 
>   ksmserver/themes/contour/main.qml PRE-CREATION 
>   ksmserver/themes/contour/metadata.desktop PRE-CREATION 
>   ksmserver/themes/default/ContextMenu.qml PRE-CREATION 
>   ksmserver/themes/default/KSMButton.qml PRE-CREATION 
>   ksmserver/themes/default/MenuItem.qml PRE-CREATION 
>   ksmserver/themes/default/main.qml PRE-CREATION 
>   ksmserver/themes/default/metadata.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103621/diff/diff
> 
> 
> Testing
> -------
> 
> Works in Plasma Active Two using MeeGo image and KDE SC 4.8. It does not work in 4.7.x because the patch requires kde-runtime 4.8's declarative imports.
> 
> There is still one bug left: keyboard nagivation works with TAB, BACKSPACE, and arrow-keys, but only the TAB key works at first. You always have to press the TAB key at least once for the other keys to work for navigation. The first TAB press only activates the navigation, you still need a second press to actually move focus to the next element.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/103621/s/400/
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120104/231470ed/attachment.htm>