Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103610/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

The attached patch addresses the issue of SSL handshake failure in TcpSlaveBase due to lack of support for disabling SSL compression in Qt. As of 4.8, Qt supports this functionality so this patch implements support for activing that support in KTcpSocket and using it from KIO::TcpSlaveBase so that users will be able to browse SSL protected sites that do not support SSL compression.

Note that this patch also changes the code in TcpSlaveBase not to tear the connection down when SSL handshake fails. Instead it now simply retries the SSL handshake with different SSL parameters. This drastically improves the performance of connecting to sites where the original handshake fails and other SSL modes have be tried, e.g. SSLv3.


This addresses bug 275524.
    http://bugs.kde.org/show_bug.cgi?id=275524


Diffs
-----

  kdecore/network/ktcpsocket.h e038c64 
  kdecore/network/ktcpsocket.cpp eed2a86 
  kio/kio/tcpslavebase.h fea2c08 
  kio/kio/tcpslavebase.cpp d0f92b4 

Diff: http://git.reviewboard.kde.org/r/103610/diff/diff


Testing
-------

Visit the site listed in the bug report: 
https://tim.rz.rwth-aachen.de/mail-lifecycle/


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/3a19873d/attachment.htm>