Review Request: Do not randomly change the state of Konqueror's Bookmark toolbar when users modify toolbar settings.

[Dawit Alemayehu]

> On Jan. 2, 2012, 10:47 a.m., David Faure wrote:
> > Assuming this doesn't hide the bar when it shouldn't (on startup, or when the user asks to see it), this looks ok.

AFAICT, it does not. If you turn on the bookmark toolbar, close konqueror and start it again, the bookmark is visible.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103580/#review9430
-----------------------------------------------------------


On Dec. 30, 2011, 6:47 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103580/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2011, 6:47 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Right now if you configure Konqueror's toolbars and press Apply or OK, the Bookmark toolbar is made visible regardless of its previous state. Even if you choose to hide the toolbar, it will still be shown after the toolbar settings modification. This patch fixes that by preserving the visibility state of the previous bookmark toolbar.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp 3b6e418 
> 
> Diff: http://git.reviewboard.kde.org/r/103580/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/13379a65/attachment.htm>