Review Request: one assigment and one duplicated test
David Faure
faure at kde.org
Mon Jan 2 11:06:49 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103599/#review9437
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Dec. 31, 2011, 11:33 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103599/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2011, 11:33 a.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Description
> -------
>
> Change the duplicated !gNP_Initialize by the unchecked !gNP_Shutdown.
> Assign, instead of compare i18n("None")
>
> Also, I can remove the empty line and tab.
>
>
> Diffs
> -----
>
> nsplugins/wrapper/wrapper.c dfaf7ed
> plasma/applets/folderview/folderview.cpp d620a7d
>
> Diff: http://git.reviewboard.kde.org/r/103599/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120102/ca0e9966/attachment.htm>
More information about the kde-core-devel
mailing list