Review Request: Add KFontDialog->setSampleText()
Thomas Lübking
thomas.luebking at web.de
Sun Jan 1 20:44:06 GMT 2012
> On Jan. 1, 2012, 5:16 p.m., Anders Lund wrote:
> > Using KDE 4.7.4 I can just click and type there.
>
> Thomas Lübking wrote:
> I guess it's by more about defaults, since the technical use of fonts has other demands (unambiguity) than the regular one (pretty) which the regular user however might not implicitly be aware of.
>
> Anders Lund wrote:
> I hope the option to get a view of the font is not limited to technicalities. For many people general readability and asteathics are important parameters as well! And the problem with iIlLoO0 could be considered important for general font usage too.
I'm not quite sure what limitations you fear - the option to change the string is not to be touched, neither is the global default one.
The driving aspect of this particular case is to "have a usable monospace font" - and how many fonts with variable width do you know which slash the "0"?
Code and shell requirements differ a lot from regular font quality aspects, eg. monospace is usually a braindead idea if you care about readability and there have always been flamewars on the best monospaced font while it should actually be "the least crap one".
This here only covers the issue that there're quite some monospaces which look great at first sight - but then fail on "I == l" or "0 == O" or not being monospaced across weights (what means you cannot use bold glyphs for keywords)
Therefore Kurt wants to use a very special string to stress this in Konsole's font dialog. Kate may pick this up, but elsewhere you're far better done with the fox or lorem ipsum.
@Kurt: maybe also add "|1!o"?
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103357/#review9409
-----------------------------------------------------------
On Dec. 8, 2011, 4:11 a.m., Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103357/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2011, 4:11 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Currently there is no way to change the sample text in KFontDialog. I would like to change the sample text in Konsole to display characters that may appear similar in some fonts (iIlLoO0).
>
>
> Diffs
> -----
>
> kdeui/fonts/kfontdialog.h 371345e
> kdeui/fonts/kfontdialog.cpp efd6a35
>
> Diff: http://git.reviewboard.kde.org/r/103357/diff/diff
>
>
> Testing
> -------
>
> Compiled on master branch and testing in Konsole.
>
>
> Thanks,
>
> Kurt Hindenburg
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120101/f3783770/attachment.htm>
More information about the kde-core-devel
mailing list