Review Request: kcontrol mouse coursor: better performance

[Lukas Sommer]

> On Feb. 26, 2012, 7:12 p.m., Christoph Feck wrote:
> > With Qt 4.8, there is usually no difference between QImage and QPixmap, so I do not think we should try to be smart here. There general rule is: Use QImage, if you need to access individual pixels, use QPixmap everywhere else. This way we can benefit from any optimizations that can only be applied to opaque datatypes (which QImage isn't).

Okay.

It was just because Fredrik Höglund commented in #101701 that I should implement this with a later patch.

However, if this isn't necessary with Qt 4.8 anymore, I discard this review request.


- Lukas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104077/#review10918
-----------------------------------------------------------


On Feb. 25, 2012, 5:42 p.m., Lukas Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104077/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2012, 5:42 p.m.)
> 
> 
> Review request for KDE Base Apps, KDE Runtime, kdelibs, Fredrik Höglund, and Christoph Feck.
> 
> 
> Description
> -------
> 
> With review request r101701 being submitted, there is still a remaining issue that wasn't solved: Scaling a QImage is expensive. So it is better to keep the data as QPixmap as long as necessary.
> 
> This patch implements a less expensive behaviour.
> 
> 
> Diffs
> -----
> 
>   kcontrol/input/xcursor/cursortheme.cpp 2c8c260 
>   kcontrol/input/xcursor/themepage.cpp 0f678ed 
> 
> Diff: http://git.reviewboard.kde.org/r/104077/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukas Sommer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120229/b9ffca33/attachment.htm>