Review Request: Always request small icons for Konqueror's status bar.

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104071/
-----------------------------------------------------------

(Updated Feb. 29, 2012, 5:04 p.m.)


Review request for KDE Base Apps and David Faure.


Changes
-------

Cleaned up the patch and made it easier to maintain.


Description
-------

The attached patch fixes the issue of the status bar becoming huge when, for whatever reason, the requested icon could not be found and a default icon is returned instead. In this case the code that was requesting the Konqueror status bar indicator icons was using the convenience function UserIcon from KIconLoader. 

The problem with using UserIcon is that the size of the icon returned is completely dependent upon the actual size of the requested icon on disk. If the icon is large, then a large icon is returned. As such when the icon cache is utterly corrupted for whatever reason and returns some default icon with its default (actual) size, Konqueror's status bar balloons to one quarter of the main window size. Not what we want. To avoid this, the patch converts the code to use KIconLoader::loadIcon with the icon size set to KIconLoader::SizeSmall instead of the related convenience function.


This addresses bug 294321.
    http://bugs.kde.org/show_bug.cgi?id=294321


Diffs (updated)
-----

  konqueror/src/konqframestatusbar.cpp 0142bd0 

Diff: http://git.reviewboard.kde.org/r/104071/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120229/120c68ce/attachment.htm>