Review Request: Test also the prefix value

Kevin Ottens ervin at kde.org
Mon Feb 27 08:04:49 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104068/#review10940
-----------------------------------------------------------

Ship it!


I still don't have the fine knowledge of tarball structure. :-)

But this patch looks sane and coherent with previous reviews, if it helps supporting more files, go for it.

- Kevin Ottens


On Feb. 24, 2012, 5:31 p.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104068/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 5:31 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> We need to test if there is a prefix value because the file name can be
> null and the prefix can have a value and in this case we don't reset n.
> 
> It's the last part to fix the bug 258737
> 
> 
> This addresses bug 258737.
>     http://bugs.kde.org/show_bug.cgi?id=258737
> 
> 
> Diffs
> -----
> 
>   kdecore/io/ktar.cpp 9c3a010 
> 
> Diff: http://git.reviewboard.kde.org/r/104068/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Bensi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120227/d9701b01/attachment.htm>


More information about the kde-core-devel mailing list