Review Request: Test and add prefix value

Kevin Ottens ervin at kde.org
Mon Feb 27 08:03:46 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104067/#review10939
-----------------------------------------------------------



kdecore/io/ktar.cpp
<http://git.reviewboard.kde.org/r/104067/#comment8896>

    I would go for constData() here instead of data().


- Kevin Ottens


On Feb. 24, 2012, 5:29 p.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104067/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 5:29 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> We can have a prefix value in header at 0x159, if the value of the
> prefix are not null, we need to add this to the name value, with '/' to
> separate.
> 
> This fix only a part of the bug 258737
> 
> 
> This addresses bug 258737.
>     http://bugs.kde.org/show_bug.cgi?id=258737
> 
> 
> Diffs
> -----
> 
>   kdecore/io/ktar.cpp 9c3a010 
> 
> Diff: http://git.reviewboard.kde.org/r/104067/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario Bensi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120227/fb54775a/attachment.htm>


More information about the kde-core-devel mailing list