Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

Lamarque Vieira Souza lamarque at kde.org
Fri Feb 24 00:05:20 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104051/
-----------------------------------------------------------

(Updated Feb. 24, 2012, 12:05 a.m.)


Review request for KDE Runtime.


Changes
-------

Version without #ifdef's. Now it checks if kcminit is running during runtime, if not then disables the two timeouts that causes 20s delay in ksmserver startup. Still need to check if this change causes any regressions when compiling kde-workspace with desktop profile.


Description
-------

If kde-workspace is compiled with mobile profile or for any platform but X11 then kcminit is not compiled. That is the case for Plasma Active, whre we compiles kde-workspace with mobile profile. That causes kcmserver wait 10 seconds everytime it tries to contact kcminit (twice during ksmserver startup). This patch disables the timeouts in ksmserver if it was compiled with mobile profile enabled.


This addresses bug 294619.
    http://bugs.kde.org/show_bug.cgi?id=294619


Diffs (updated)
-----

  ksmserver/startup.cpp e166286 

Diff: http://git.reviewboard.kde.org/r/104051/diff/


Testing
-------

Tested using Plasma Active devel image.


Thanks,

Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120224/f7853cff/attachment.htm>


More information about the kde-core-devel mailing list