Review Request: New KPart extension for manupilating a browser engine's settings

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/#review10807
-----------------------------------------------------------



khtml/khtml_ext.cpp
<http://git.reviewboard.kde.org/r/103973/#comment8760>

    OK that's more than I expected. A simple "return true;" would have been enough IMHO, to mean "yep, I support this property".
    
    This code looks ok, as "extra precaution",  but is there really a code path in setAutoloadImages which would not just store the given value?
    
    My idea was just that in the future when someone adds a new setting, the app code can be notified of whether the setting is supported or not. For now, obviously, khtmlpart implements all the settings, so it would just be "return true" in every branch of the switch (and return false at the bottom).


- David Faure


On Feb. 21, 2012, 5:59 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103973/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2012, 5:59 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_ext.h ced53a3 
>   khtml/khtml_ext.cpp 6e8a846 
>   kparts/htmlextension.h 9833d9a 
> 
> Diff: http://git.reviewboard.kde.org/r/103973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120221/892c724a/attachment.htm>