Review Request: Replicate the existing KConfigDialog constructor and change one argument type

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103716/
-----------------------------------------------------------

(Updated Feb. 21, 2012, 3:56 p.m.)


Review request for kdelibs and David Faure.


Description
-------

Use case: there are applications like kanagram which would be nice to have
running on several platforms, like handsets; for instance Harmattan on N9. It
would be nice to use the same settings code generation in certain cases for all
the platforms since the additions of KConfigSkeleton on the top of
KCoreConfigSkeleton are the font and color settings. These are currently not
used in many KDE applications. Hence, it should not be mandatory. The kdeui
module is unlikely welcome on mobile platforms, especially in appstores with
its sizes and complexity for no real need.

KConfigDialogManager has apparently already two constructors; one with
KConfigSkeleton argument type, and yet another with KCoreConfigSkeleton. It
looks like a situation where the KCoreConfigSkeleton version was added later.

KConfigDialog does not have a constructor yet with KCoreConfigSkeleton argument
type yet; it has probably somehow been missed so far. Changing the current
constructor to KCoreConfigSkeleton usage is not possible in the 4.X major
version because of the consequences (ABI breakage). Thereby, the freshly
replacated constructor. The proper fix can be filed against frameworks where
there is only one, and properly working constructor.


Diffs (updated)
-----

  kdeui/dialogs/kconfigdialog.h 2ac0eda 
  kdeui/dialogs/kconfigdialog.cpp e815e54 

Diff: http://git.reviewboard.kde.org/r/103716/diff/


Testing
-------

On Archlinux (build test only)


Thanks,

Laszlo Papp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120221/07d3a8ee/attachment.htm>