Review Request: Fix signal/slot connections in kcmdolphinviewmodes

Peter Penz peter.penz19 at gmail.com
Mon Feb 20 18:27:42 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104033/#review10769
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks fine!

- Peter Penz


On Feb. 20, 2012, 6:15 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104033/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 6:15 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Description
> -------
> 
> The attached patch fixes a QObject no such slot warning messages in Dolphin's viewmode kcm.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.h 4ec29db 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp 5441b78 
> 
> Diff: http://git.reviewboard.kde.org/r/104033/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/27dce2e7/attachment.htm>


More information about the kde-core-devel mailing list