Review Request: make folderview compile with Qt 4.7

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104030/#review10765
-----------------------------------------------------------



plasma/applets/folderview/actionoverlay.cpp
<http://git.reviewboard.kde.org/r/104030/#comment8741>

    Maybe the qt-4.8 code path that you removed, should still be there, in #if QT_VERSION >= 0x040800 ?
    
    This way the shorter code is used, and once qt-4.8 is required we can get rid of the longer version of the code. Thinking long term here -- better keep the code short, which won't happen if this commit is made "as is".


- David Faure


On Feb. 20, 2012, 2:55 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104030/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2012, 2:55 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently, kde-baseapps does not compile against Qt 4.7, in contrast to what cmake checks. This patch fixes the only place where Qt 4.8 API was used.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/actionoverlay.cpp 791cfdf 
> 
> Diff: http://git.reviewboard.kde.org/r/104030/diff/
> 
> 
> Testing
> -------
> 
> compile-tested
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120220/aa6f2e93/attachment.htm>