Review Request: New KPart extension for manupilating a browser engine's settings

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/
-----------------------------------------------------------

(Updated Feb. 18, 2012, 9:09 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Renamed get/set functions from "browserSettings" to "attribute" and "setBrowserSettings" to "setAttribute" respectively.


Description
-------

This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.


Diffs (updated)
-----

  includes/CMakeLists.txt 2e7fe31 
  includes/KParts/BrowserSettingsExtension PRE-CREATION 
  khtml/khtml_ext.h ced53a3 
  khtml/khtml_ext.cpp 6e8a846 
  khtml/khtml_part.cpp 24589e4 
  kparts/CMakeLists.txt 96fa31f 
  kparts/browsersettingsextension.h PRE-CREATION 
  kparts/browsersettingsextension.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103973/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120218/1d08258a/attachment.htm>