Review Request: Don't set an RPATH when installed into multiarch dir

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103422/#review10720
-----------------------------------------------------------

Ship it!


You may consider to add checking also CMAKE_C_IMPLICIT_LINK_DIRECTORIES .
CMAKE_(C|CXX)_IMPLICIT_LINK_DIRECTORIES are new since cmake 2.8.0, so please check that it doesn't break when cmake 2.6.4 is used.


- Alexander Neundorf


On Dec. 16, 2011, 8:41 a.m., Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103422/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 8:41 a.m.)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Don't set an RPATH when installed into a multiarch dir (e.g. /usr/lib/x86_64-linux-gnu).
> On Debian and Ubuntu /usr/lib/<arch> are system lib dirs.
> 
> On a Kubuntu 11.10 system CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES contains
> /lib
> /usr/lib
> /usr/lib32
> /usr/lib64
> and CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES contains
> /usr/lib/gcc/x86_64-linux-gnu/4.6.1
> /usr/lib/x86_64-linux-gnu
> /usr/lib
> /lib/x86_64-linux-gnu
> /lib
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindKDE4Internal.cmake 6d65e61 
> 
> Diff: http://git.reviewboard.kde.org/r/103422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Geyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120218/a7809270/attachment.htm>