Review Request: Don't set an RPATH when installed into multiarch dir

[Modestas Vainius]

> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote:
> > Actually this looks more like a cmake bug, the contents of CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong.
> > What version of cmake are you using ?
> >
> 
> Felix Geyer wrote:
>     2.8.5 (with this commit cerry-picked: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=317d077f) and 2.8.6. Same output on both.
>     What should it look like?
> 
> Rex Dieter wrote:
>     For what it's worth, on my fedora 16 x86_64 box:
>     CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES "/lib;/usr/lib;/usr/lib32;/usr/lib64"
>     CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES "/usr/lib/gcc/x86_64-redhat-linux/4.6.2;/usr/lib64;/lib64;/usr/lib"
>     
>     so that matches reasonably with felix.  though, thats besides the point here, which is to avoid rpath'ing CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES items too, right?
> 
> Rex Dieter wrote:
>     oh, and using cmake-2.8.7-4.fc16.x86_64 here

CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES is static while CMAKE_{CXX,C}_IMPLICIT_LINK_DIRECTORIES are dynamic (preseeded with information from compiler). That's why it is more complete and correct.


- Modestas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103422/#review9012
-----------------------------------------------------------


On Dec. 16, 2011, 8:41 a.m., Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103422/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 8:41 a.m.)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> Don't set an RPATH when installed into a multiarch dir (e.g. /usr/lib/x86_64-linux-gnu).
> On Debian and Ubuntu /usr/lib/<arch> are system lib dirs.
> 
> On a Kubuntu 11.10 system CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES contains
> /lib
> /usr/lib
> /usr/lib32
> /usr/lib64
> and CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES contains
> /usr/lib/gcc/x86_64-linux-gnu/4.6.1
> /usr/lib/x86_64-linux-gnu
> /usr/lib
> /lib/x86_64-linux-gnu
> /lib
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindKDE4Internal.cmake 6d65e61 
> 
> Diff: http://git.reviewboard.kde.org/r/103422/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Geyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120218/8b227c4e/attachment.htm>