Review Request: make Speller::spellCheckerFound() return true when the dict for the current language is found (important when there was no dict for default language)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103729/#review10673
-----------------------------------------------------------


This review has been submitted with commit d87d8268950ae6e849b2633ff3341ee0f0dc1053 by Nick Shaforostoff to branch KDE/4.8.

- Commit Hook


On Jan. 18, 2012, 5:35 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103729/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 5:35 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> right now in cases when the dictionary for default language cannot be found Speller::spellCheckerFound() always returns false, even after a langcode for the existing dictionary is passed via setCurrentLanguage().
> 
> This patch sets spellCheckerFound to true if the dict is found for the language being set, and false in another case.
> Actually, the patch makes spellCheckerFound just a cached value of d->dict->isValid().
> 
> in the bug 256896 you can find users reporting this problem in addition to another one (regarding using 'language_COUNTRY' dictionaries when only 'language' is specified)
> 
> 
> This addresses bug 256896.
>     http://bugs.kde.org/show_bug.cgi?id=256896
> 
> 
> Diffs
> -----
> 
>   kdeui/sonnet/highlighter.cpp 3f478f0 
> 
> Diff: http://git.reviewboard.kde.org/r/103729/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120215/0b10ef82/attachment.htm>