Review Request: New KPart extension for manupilating a browser engine's settings

[Dawit Alemayehu]

> On Feb. 13, 2012, 7:44 p.m., Laszlo Papp wrote:
> > Is it acceptable to send new features/extensions against KDE4.x ? I had the impression only bugfixes, and I tried to push my changes against the frameworks branch instead. I may have been wrong with that though.

This is not a new feature. Even though the class itself is brand new, it is needed to address issues in the plugins that causes two browser engines to be loaded at the same time. IOW, it is a necessary addition to address a bug or a current failure, not to simply add a new feature.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103973/#review10609
-----------------------------------------------------------


On Feb. 13, 2012, 7 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103973/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2012, 7 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> This patch adds a new KPart extension, BrowserSettingsExtension, for setting as well as accessing a browser engine's properties in a generic fashion from KPart plugins. This is yet another step towards making Konqueror's plugins and settings module independent of the default browser engine in use. IOW, they do not have to directly link to a specific browser engine.
> 
> 
> Diffs
> -----
> 
>   kparts/CMakeLists.txt 96fa31f 
>   kparts/browsersettingsextension.h PRE-CREATION 
>   kparts/browsersettingsextension.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103973/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120213/0a466bfa/attachment.htm>