Review Request: Normalize signal/slot connections in kdelibs using the Qt normalize utility
Dawit Alemayehu
adawit at kde.org
Mon Feb 13 16:59:48 GMT 2012
> On Feb. 13, 2012, 11:36 a.m., David Faure wrote:
> > Long ago we had decided to NOT do a global change for this, but if Qt provides a tool, this reduces the risk for errors indeed.
> > Well, I don't fully trust the tool either, so I actually reviewed this patch, and it looks ok to me. If something breaks, you will be blamed though, not the tool :-)
I have no issue with taking the blame since it is my change even if the tool is the cause. The issue I have is which branch to commit this to ? origin/master, origin/KDE/4.8 (against which patch is made) or origin/frameworks ?
- Dawit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103728/#review10590
-----------------------------------------------------------
On Jan. 29, 2012, 6:43 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103728/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2012, 6:43 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> This patch simply normalizes all signal/slot connections in the kdelibs. It was done using Qt's normalize tool. This relatively simple and safe change provides a performance win however minor it may be. Any objections ?
>
>
> Diffs
> -----
>
> dnssd/avahi-domainbrowser.cpp b60afc4
> dnssd/avahi-publicservice.cpp 376ea018
> dnssd/avahi-remoteservice.cpp 4f08870
> dnssd/avahi-servicebrowser.cpp a648446
> dnssd/avahi-servicetypebrowser.cpp ef16f8a
> dnssd/domainmodel.cpp 234f3fa
> dnssd/mdnsd-servicebrowser.cpp c52daf5
> interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp 15f590c
> interfaces/kmediaplayer/kfileaudiopreview/mediacontrols.cpp d5882cc
> kde3support/kdecore/k3procio.cpp 3cdca07
> kde3support/kdeui/k3iconview.cpp 3993c35
> kde3support/kdeui/k3iconviewsearchline.cpp e95c0e9
> kde3support/kdeui/k3listbox.cpp 7c22d1f
> kde3support/kdeui/k3listview.cpp 8fd170d
> kde3support/kdeui/k3listviewsearchline.cpp 5404a8f
> kde3support/kdeui/k3passworddialog.cpp b9e40d8
> kde3support/kdeui/k3spell.cpp 387abff
> kde3support/kdeui/k3spelldlg.cpp 241040a
> kde3support/kdeui/k3syntaxhighlighter.cpp 7f0a416
> kde3support/kdeui/k3textedit.cpp bf6d9c9
> kde3support/kio/kfile/k3filetreeview.cpp 091058f
> kde3support/kio/kfile/k3fileview.cpp f3c395b
> kde3support/kio/kfile/kfiletreebranch.cpp abc4e32
> kde3support/kparts/dockmainwindow3.cpp b39d0ef
> kde3support/tests/itemcontainertest.cpp 9d15180
> kde3support/tests/k3processtest.cpp 919c7ea
> kde3support/tests/kcommandtest.cpp 792b512
> kde3support/tests/kdockwidgetdemo.cpp eb9fa71
> kdecore/auth/backends/dbus/DBusHelperProxy.cpp 3d13400
> kdecore/auth/kauthactionwatcher.cpp c4c44b7
> kdecore/io/kdirwatch.cpp e0a4056
> kdecore/jobs/kjobtrackerinterface.cpp a189b8f
> kdecore/network/k3clientsocketbase.cpp acbb824
> kdecore/network/k3datagramsocket.cpp c009ee2
> kdecore/network/k3resolver.cpp efc7428
> kdecore/network/k3serversocket.cpp 04c7c98
> kdecore/network/ktcpsocket.cpp 9bcfef3
> kdecore/sonnet/backgroundchecker.cpp 5da0d51
> kdecore/sonnet/tests/test_dialog.cpp 4689c36
> kdecore/tests/kdirwatchtest.cpp 9c755bb
> kdecore/tests/kdirwatchtest_gui.cpp 1bfb7e6
> kdecore/tests/kjobtest.cpp d3c0440
> kded/kded.cpp 1497fa0
> kdeui/actions/kactionmenu.cpp f4a1391
> kdeui/actions/kfontaction.cpp 111913d
> kdeui/actions/kselectaction.cpp 1b70da6
> kdeui/actions/kstandardaction.cpp 3475ad1
> kdeui/actions/ktoggleaction.cpp 25123cd
> kdeui/actions/ktoolbarpopupaction.cpp 0a2cd75
> kdeui/actions/ktoolbarspaceraction.cpp 58f4ed0
> kdeui/colors/kcolordialog.cpp 3e52c16
> kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp b9d2a9b
> kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp c15d928
> kdeui/dialogs/kassistantdialog.cpp 8f9f702
> kdeui/dialogs/kbugreport.cpp 582f3b0
> kdeui/dialogs/kconfigdialogmanager.cpp 0890c0b
> kdeui/dialogs/kcupsoptionsjobwidget_p.cpp 380ffa4
> kdeui/dialogs/kdialog.cpp 0cabb85
> kdeui/dialogs/kedittoolbar.cpp d3b7a2b
> kdeui/dialogs/kinputdialog.cpp b8406ee
> kdeui/dialogs/klinkdialog.cpp bb06aac
> kdeui/dialogs/knewpassworddialog.cpp 785f9da
> kdeui/dialogs/kpassworddialog.cpp 1e0afab
> kdeui/dialogs/kshortcuteditwidget.cpp e922412
> kdeui/dialogs/kshortcutschemeseditor.cpp f159a1c
> kdeui/dialogs/kshortcutsdialog.cpp a375ac3
> kdeui/dialogs/kshortcutseditor.cpp 991f458
> kdeui/dialogs/kshortcutseditordelegate.cpp 60ddbcb
> kdeui/dialogs/kswitchlanguagedialog_p.cpp 6846742
> kdeui/dialogs/ktip.cpp 2adf019
> kdeui/findreplace/kfind.cpp 0f6dedc
> kdeui/findreplace/kfinddialog.cpp 081acd6
> kdeui/findreplace/kreplace.cpp 61b33fd
> kdeui/fonts/kfontchooser.cpp bd1185f
> kdeui/fonts/kfontdialog.cpp efd6a35
> kdeui/fonts/kfontrequester.cpp 260ac9c
> kdeui/itemviews/kbreadcrumbselectionmodel.cpp 81e1b5d
> kdeui/itemviews/kdescendantsproxymodel.cpp ae571fb
> kdeui/itemviews/kextendableitemdelegate.cpp ceeca4a
> kdeui/itemviews/kfilterproxysearchline.cpp e1873e6
> kdeui/itemviews/kidentityproxymodel.cpp 0c65759
> kdeui/itemviews/klinkitemselectionmodel.cpp 5e7751f
> kdeui/itemviews/klistwidget.cpp 5b6c3c6
> kdeui/itemviews/klistwidgetsearchline.cpp 1478e86
> kdeui/itemviews/kselectionproxymodel.cpp eca2d78
> kdeui/itemviews/ktreewidgetsearchline.cpp a019213
> kdeui/itemviews/kviewstatesaver.cpp 8418cfe
> kdeui/kernel/kapplication.cpp cc20f05
> kdeui/kernel/kclipboard.cpp 0d97567
> kdeui/kernel/kstartupinfo.cpp 2289177
> kdeui/notifications/ksystemtrayicon.cpp 6ed337a
> kdeui/paged/kpageview.cpp b26f081
> kdeui/paged/kpageview_p.cpp 5bc3fb2
> kdeui/paged/kpagewidget.cpp 1a7c0ed
> kdeui/shortcuts/kglobalaccel.cpp f331ca4
> kdeui/sonnet/dialog.cpp 90679c1
> kdeui/sonnet/dictionarycombobox.cpp 769cee3
> kdeui/sonnet/highlighter.cpp 3f478f0
> kdeui/sonnet/tests/backgroundtest.cpp 092152e
> kdeui/sonnet/tests/test_dialog.cpp df68d25
> kdeui/sonnet/tests/test_highlighter.cpp 1cea506
> kdeui/tests/kbuttongrouptest.cpp cc3fdee
> kdeui/tests/kcodecactiontest.cpp 87862fa
> kdeui/tests/kcompletioncoretest.cpp 49f8e42
> kdeui/tests/kcompletionuitest.cpp 8d6a517
> kdeui/tests/kfadewidgeteffecttest.cpp 23a820d
> kdeui/tests/kfindtest.cpp fdd112f
> kdeui/tests/khboxtest.cpp ff87b2d
> kdeui/tests/kiconeffecttest.cpp 77131a8
> kdeui/tests/klineedittest.cpp 0a222dc
> kdeui/tests/kmainwindowtest.cpp 0af6d48
> kdeui/tests/kmanagerselectiontest.cpp 6feb5c1
> kdeui/tests/kmodifierkeyinfotest.cpp 26a62c3
> kdeui/tests/kpagewidgettest.cpp 8ea825d
> kdeui/tests/kpassivepopuptest.cpp d81ac83
> kdeui/tests/kreplacetest.cpp b886f42
> kdeui/tests/kselectactiontest.cpp 8ca804e
> kdeui/tests/kstatusbartest.cpp 56d1412
> kdeui/tests/ktabwidgettest.cpp fc2bc0a
> kdeui/tests/ktoolbar_unittest.cpp 123221b
> kdeui/tests/kwindowtest.cpp 23788e8
> kdeui/tests/kxmlguitest.cpp f7ac542
> kdeui/tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp 2a02928
> kdeui/tests/proxymodeltestapp/descendantpmwidget.cpp 24e831f
> kdeui/tests/proxymodeltestapp/kreparentingproxymodel.cpp 4a8017c
> kdeui/tests/proxymodeltestsuite/dynamictreemodel.cpp 8b406f0
> kdeui/tests/proxymodeltestsuite/modelselector.cpp b3da5cc
> kdeui/tests/proxymodeltestsuite/modelspy.cpp ea88a85
> kdeui/tests/proxymodeltestsuite/modeltest.cpp 5a5a39c
> kdeui/tests/proxymodeltestsuite/proxymodeltest.cpp b6c8977
> kdeui/tests/testmodelqueuedconnections.cpp bac4b76
> kdeui/tests/testplot_widget.cpp c139b7d
> kdeui/util/kcursor.cpp 087d227
> kdeui/util/kmodifierkeyinfo.cpp 4de09c7
> kdeui/util/kpassivepopup.cpp 7e5637c
> kdeui/util/kwallet.cpp 51c741a
> kdeui/util/kwallet_mac.cpp 706ff74
> kdeui/widgets/kbuttongroup.cpp 6d57c71
> kdeui/widgets/kcharselect.cpp 905343a
> kdeui/widgets/kcmodule.cpp cf1fd6c
> kdeui/widgets/kcombobox.cpp 4bde2d5
> kdeui/widgets/kcompletionbox.cpp 6b9b050
> kdeui/widgets/kdatecombobox.cpp 647afbc
> kdeui/widgets/kdatepicker.cpp 7682949
> kdeui/widgets/kdatetable.cpp ccfc230
> kdeui/widgets/kdatetimewidget.cpp b1dcd58
> kdeui/widgets/kdatewidget.cpp 07ba2df
> kdeui/widgets/keditlistbox.cpp 576dba6
> kdeui/widgets/keditlistwidget.cpp 39b56f3
> kdeui/widgets/khelpmenu.cpp e3917e5
> kdeui/widgets/khistorycombobox.cpp 47c9828
> kdeui/widgets/klineedit.cpp 701b8f1
> kdeui/widgets/kmainwindow.cpp 41cef48
> kdeui/widgets/kmenubar.cpp 948c229
> kdeui/widgets/kpixmapregionselectorwidget.cpp 4e322a8
> kdeui/widgets/kpushbutton.cpp fd3ce65
> kdeui/widgets/krichtextwidget.cpp cf1e6c9
> kdeui/widgets/kshortcutwidget.cpp f8d93f2
> kdeui/widgets/ktabbar.cpp b9a790b
> kdeui/widgets/ktabwidget.cpp 5b268d4
> kdeui/widgets/ktextedit.cpp 9987707
> kdeui/widgets/ktimecombobox.cpp 779c9ff
> kdeui/widgets/ktoolbar.cpp cce242b
> kdeui/widgets/kurllabel.cpp 43b64cc
> kdeui/windowmanagement/kwindowsystem_win.cpp 873c86f
> kdeui/windowmanagement/kwindowsystem_x11.cpp 741393c
> kdeui/xmlgui/kmenumenuhandler_p.cpp cc3499e
> kdeui/xmlgui/ktoolbarhandler.cpp 73a6a4e
> kdeui/xmlgui/kxmlguiwindow.cpp 760b5d1
> kdewebkit/kwebpage.cpp 9147023
> kfile/kdiroperator.cpp 4def102
> kfile/kdirselectdialog.cpp 4bc3f6f
> kfile/kfilefiltercombo.cpp deb57c8
> kfile/kfileplaceeditdialog.cpp a024ff0
> kfile/kfileplacesitem.cpp a06d340
> kfile/kfileplacesmodel.cpp 96f6912
> kfile/kfileplacessharedbookmarks.cpp 9cbdcf4
> kfile/kfileplacesview.cpp 6a343b3
> kfile/kfilepreviewgenerator.cpp 9c71ff8
> kfile/kfiletreeview.cpp d96263c
> kfile/kfilewidget.cpp 960d6c4
> kfile/knewfilemenu.cpp fbb0e48
> kfile/kurlnavigator.cpp 6a8525f
> kfile/kurlnavigatorbutton.cpp 536e976
> kfile/kurlnavigatorplacesselector.cpp 28ee9c3
> kfile/tests/kfileplacesmodeltest.cpp 85625ca
> khtml/ecma/debugger/debugdocument.cpp 78c7744
> khtml/ecma/debugger/debugwindow.cpp 4438a1a
> khtml/ecma/debugger/scriptsdock.cpp be50629
> khtml/ecma/kjs_window.cpp 92f3fcd
> khtml/ecma/xmlhttprequest.cpp d441e8d
> khtml/html/html_documentimpl.cpp 5d60a21
> khtml/html/html_objectimpl.cpp 1ee642e
> khtml/java/kjavaappletserver.cpp 52e1790
> khtml/java/kjavaappletviewer.cpp 92c33e3
> khtml/java/kjavaappletwidget.cpp 7d433d4
> khtml/java/kjavadownloader.cpp eb5260e
> khtml/java/kjavaprocess.cpp ae06579
> khtml/khtml_ext.cpp 66a2748
> khtml/khtml_pagecache.cpp f3b37e0
> khtml/khtml_part.cpp 35a5785
> khtml/khtml_settings.cpp 43d2ff8
> khtml/khtmlimage.cpp 5738d85
> khtml/khtmlviewbarwidget.cpp 1a54b34
> khtml/kmultipart/kmultipart.cpp a943806
> khtml/misc/loader.cpp 38b623b
> khtml/rendering/media_controls.cpp fcf4682
> khtml/rendering/render_form.cpp aa59d3d
> khtml/rendering/render_frames.cpp c4046f3
> khtml/rendering/render_replaced.cpp 9831cdb
> khtml/test_regression.cpp d4d43da
> khtml/test_regression_gui_window.cpp 4a6022c
> khtml/testkhtml.cpp 6be32c8
> khtml/tests/testkhtmlnew.cpp 0ea8c71
> khtml/ui/findbar/khtmlfind.cpp 16f7342
> khtml/ui/findbar/khtmlfindbar.cpp c3092a3
> kinit/kinit.cpp 32cc1e8
> kinit/klauncher.cpp d8f86ca
> kinit/klauncher_main.cpp 3422ee4
> kio/kfile/kacleditwidget.cpp f42a36f
> kio/kfile/kcommentwidget.cpp a2ff7f8
> kio/kfile/kdevicelistmodel.cpp 1844bad
> kio/kfile/kfiledialog.cpp 5c7dc85
> kio/kfile/kfilemetadataprovider.cpp f88a411
> kio/kfile/kfilemetadatareader.cpp 9408adc
> kio/kfile/kfilemetainfowidget.cpp ce01dda
> kio/kfile/kfilesharedialog.cpp 3e00d35
> kio/kfile/kicondialog.cpp f106182
> kio/kfile/kimagefilepreview.cpp 8cee866
> kio/kfile/kmetaprops.cpp 65c8dee
> kio/kfile/kopenwithdialog.cpp 7033d88
> kio/kfile/kpreviewprops.cpp 2aacc9e
> kio/kfile/kpropertiesdialog.cpp 98755de
> kio/kfile/kurlcombobox.cpp 8d980fe
> kio/kfile/kurlrequester.cpp 444ba7f
> kio/kio/accessmanagerreply_p.cpp 942f0e5
> kio/kio/chmodjob.cpp 939de2c
> kio/kio/copyjob.cpp 306e60f
> kio/kio/delegateanimationhandler.cpp bf5ee2b
> kio/kio/deletejob.cpp 6722b43
> kio/kio/directorysizejob.cpp 3ca8599
> kio/kio/filejob.cpp 98a9d06
> kio/kio/fileundomanager.cpp f580c29
> kio/kio/forwardingslavebase.cpp 573fad2
> kio/kio/job.cpp 94bffc1
> kio/kio/kautomount.cpp 80f860f
> kio/kio/kdatatool.cpp ddd2698
> kio/kio/kdirlister.cpp ec3d622
> kio/kio/kdirmodel.cpp c8de5a3
> kio/kio/kfileshare.cpp 6f77c59
> kio/kio/knfsshare.cpp e5bc9ce
> kio/kio/kpasswdserver.cpp 0705dc5
> kio/kio/krun.cpp 1ff6979
> kio/kio/ksambashare.cpp 95b6c55
> kio/kio/kurlcompletion.cpp 8b8c8a7
> kio/kio/metainfojob.cpp 6fc6712
> kio/kio/netaccess.cpp b838382
> kio/kio/pastedialog.cpp 9bd773d
> kio/kio/previewjob.cpp 5635875
> kio/kio/renamedialog.cpp aa60a94
> kio/kio/scheduler.cpp 6b36d9d
> kio/kio/skipdialog.cpp e65ea51
> kio/kssl/kcm/cacertificatespage.cpp c83b757
> kio/kssl/ksslkeygen.cpp 93b0103
> kio/misc/kpac/discovery.cpp dfde7d2
> kio/misc/kpac/downloader.cpp 8d9f7f3
> kio/tests/fileundomanagertest.cpp 08db2a1
> kio/tests/jobremotetest.cpp 9e0a4ff
> kio/tests/jobtest.cpp 29ce641
> kio/tests/kdcopcheck.cpp e237327
> kio/tests/kdirlistertest.cpp a9a46cc
> kio/tests/kdirlistertest_gui.cpp 14fc7ae
> kio/tests/kdirmodeltest.cpp d3ad365
> kio/tests/kfdtest.cpp 225db2d
> kio/tests/kioslavetest.cpp 5536abc
> kio/tests/previewtest.cpp 7c8d62d
> kio/tests/speed.cpp 056d081
> kioslave/http/http.cpp 95dbe78
> kjsembed/examples/kjsconsole/console.cpp 0bb5707
> kjsembed/examples/kjsconsole/numberedtextview.cpp 2742597
> kjsembed/kjscmd/kjscmd.cpp 8e88133
> knewstuff/knewstuff2/core/coreengine.cpp 7aaf610
> knewstuff/knewstuff2/core/entryloader.cpp 5ae425b
> knewstuff/knewstuff2/core/providerloader.cpp 8ec0bef
> knewstuff/knewstuff2/core/security.cpp 93497ed
> knewstuff/knewstuff2/dxs/dxs.cpp 003a447
> knewstuff/knewstuff2/dxs/dxsengine.cpp f51be8c
> knewstuff/knewstuff2/dxs/soap.cpp 9e3db65
> knewstuff/knewstuff2/engine.cpp ec046bf
> knewstuff/knewstuff2/ui/downloaddialog.cpp 48ddc7f
> knewstuff/knewstuff2/ui/itemsmodel.cpp 0651595
> knewstuff/knewstuff2/ui/itemsview.cpp 1cd1120
> knewstuff/knewstuff2/ui/itemsviewdelegate.cpp 2244bc6
> knewstuff/knewstuff2/ui/kdxsbutton.cpp 79e0c02
> knewstuff/knewstuff2/ui/kdxscomments.cpp 9d89bf7
> knewstuff/knewstuff2/ui/qasyncimage.cpp 8568e1c
> knewstuff/knewstuff3/attica/atticaprovider.cpp 90ae4db
> knewstuff/knewstuff3/core/engine.cpp 55abc50
> knewstuff/knewstuff3/core/security.cpp 7d44ba4
> knewstuff/knewstuff3/core/xmlloader.cpp 8633466
> knewstuff/knewstuff3/downloadwidget.cpp 9f4c774
> knewstuff/knewstuff3/staticxml/staticxmlprovider.cpp 4a81f3f
> knewstuff/knewstuff3/ui/imageloader.cpp cc63f32
> knewstuff/knewstuff3/ui/itemsgridviewdelegate.cpp 56ccb53
> knewstuff/knewstuff3/ui/itemsviewdelegate.cpp 95553e5
> knewstuff/knewstuff3/upload/atticahelper.cpp f91d4a6
> knewstuff/knewstuff3/uploaddialog.cpp 44c7ea3
> knewstuff/tests/knewstuff2_cache.cpp 070129b
> knewstuff/tests/knewstuff2_download.cpp 4033e8a
> knewstuff/tests/knewstuff2_test.cpp 104653c
> knotify/config/knotifyconfigwidget.cpp 60f3a51
> knotify/config/knotifyeventlist.cpp c5d0b15
> knotify/tests/knotifytestwindow.cpp 0e0f909
> kparts/browserextension.cpp bd65122
> kparts/browserrun.cpp b8cc39d
> kparts/mainwindow.cpp bd21a54
> kparts/part.cpp b9c8be5
> kparts/partmanager.cpp 2b0e027
> kparts/scriptableextension.cpp 38c8201
> kparts/tests/notepad.cpp faa591e
> kparts/tests/testmainwindow.cpp d85abc2
> kpty/tests/kptyprocesstest.cpp e5aea68
> kross/core/actioncollection.cpp 4c10b69
> kross/modules/form.cpp fbb2828
> kross/ui/model.cpp a66ef29
> kross/ui/view.cpp f8dab88
> kutils/kcmodulecontainer.cpp 7a72eec
> kutils/kcmultidialog.cpp 5e11be2
> kutils/kemoticons/kemoticons.cpp b37b0d8
> kutils/kemoticons/tests/main.cpp f993cd2
> kutils/ksettings/componentsdialog.cpp 94c4be8
> kutils/ksettings/dialog.cpp 03a3104
> kutils/ksettings/dispatcher.cpp c5b88d6
> kutils/ksettings/pluginpage.cpp be6a7ba
> nepomuk/core/nepomukmainmodel.cpp 7e48a79
> nepomuk/query/queryserviceclient.cpp cd402e1
> nepomuk/test/ratingpaintertestwidget.cpp 8d87798
> nepomuk/ui/kedittagsdialog.cpp dc5ace9
> nepomuk/ui/ktagcloudwidget.cpp 8914827
> nepomuk/ui/ktagdisplaywidget.cpp e7f53bd
> nepomuk/ui/nepomukmassupdatejob.cpp cf7a9c6
> nepomuk/ui/tagwidget.cpp f5254b4
> nepomuk/utils/daterangeselectionwidget.cpp a3c4979
> nepomuk/utils/facetwidget.cpp 0a443fe
> nepomuk/utils/searchwidget.cpp de609ab
> plasma/applet.cpp 6db48db
> plasma/containment.cpp 6840b64
> plasma/datacontainer.cpp 33d8157
> plasma/dataengine.cpp 259ac2e
> plasma/dataenginemanager.cpp 988fe76
> plasma/deprecated/animator.cpp 03d40d6
> plasma/extenders/extender.cpp 74de8c9
> plasma/private/associatedapplicationmanager.cpp 9da0fd2
> plasma/private/kineticscroll.cpp fe16228
> plasma/private/qtjolie-branch/qtjolie/serverthread.cpp a609e2f
> plasma/private/qtjolie-branch/tests/calculatorservice.cpp 23dd972
> plasma/private/remoteservice.cpp 6c15fd1
> plasma/private/serviceprovider.cpp 6f1d905
> plasma/private/storage.cpp 717a346
> plasma/scripting/wallpaperscript.cpp edca37d
> plasma/tests/testcontainmentactionsplugin/test.cpp 05066b6
> plasma/view.cpp c4aa835
> plasma/wallpaper.cpp 35d744f7
> plasma/widgets/combobox.cpp d52eb0a
> plasma/widgets/lineedit.cpp d000439
> plasma/widgets/videowidget.cpp d79a9fd
> plasma/widgets/webview.cpp f85881c
> security/crypto/certexport.cpp b4933e7
> security/crypto/crypto.cpp 465f1dd
> solid/solid/acadapter.cpp 2601600
> solid/solid/backends/fakehw/fakedevice.cpp d727492
> solid/solid/backends/fakehw/fakegenericinterface.cpp 8f4b8e2
> solid/solid/backends/fakehw/fakestorageaccess.cpp d8d6ca7
> solid/solid/backends/fstab/fstabhandling.cpp 68db263
> solid/solid/backends/fstab/fstabstorageaccess.cpp e8d519d
> solid/solid/backends/hal/halacadapter.cpp 0ca1f88
> solid/solid/backends/hal/halbattery.cpp 0d95c36
> solid/solid/backends/hal/halbutton.cpp 1669fde
> solid/solid/backends/hal/halcdrom.cpp fe54b5a
> solid/solid/backends/hal/haldevice.cpp 528b183
> solid/solid/backends/hal/halfstabhandling.cpp 32a7031
> solid/solid/backends/hal/halgenericinterface.cpp 0dd2f03
> solid/solid/backends/hal/halmanager.cpp 7208c52
> solid/solid/backends/hal/halstorageaccess.cpp d280013
> solid/solid/backends/kupnp/kupnpmanager.cpp 18cf9af
> solid/solid/backends/udev/udevgenericinterface.cpp 174beec
> solid/solid/backends/udisks/udisksgenericinterface.cpp 55b60dd
> solid/solid/backends/udisks/udisksopticaldrive.cpp 4ed0c80
> solid/solid/backends/udisks/udisksstorageaccess.cpp f16b277
> solid/solid/backends/upnp/upnpinternetgateway.cpp be97754
> solid/solid/backends/wmi/wmiacadapter.cpp e66e426
> solid/solid/backends/wmi/wmibattery.cpp cbd3ce7
> solid/solid/backends/wmi/wmibutton.cpp 575afe1
> solid/solid/backends/wmi/wmicdrom.cpp de95621
> solid/solid/backends/wmi/wmigenericinterface.cpp b590d3a
> solid/solid/backends/wmi/wmistorageaccess.cpp 32d6c01
> solid/solid/battery.cpp 9d05009
> solid/solid/button.cpp 05cdb8f
> solid/solid/device.cpp b168139
> solid/solid/devicemanager.cpp 59f32a7
> solid/solid/genericinterface.cpp 1f27725
> solid/solid/internetgateway.cpp 9f0ceb2
> solid/solid/networking.cpp a838b98
> solid/solid/opticaldrive.cpp 5249331
> solid/solid/storageaccess.cpp 2a47c2f
> solid/tests/halbasictest.cpp cef8c84
> solid/tests/networkingclient.cpp ffdaafa
> solid/tests/solidhwtest.cpp 8cdcb1f
> solid/tests/solidnettestdbusservice.cpp 0946cfe
> threadweaver/Examples/Jobs/Jobs.cpp 08347cb
> threadweaver/Examples/Jobs/WeaverObserverTest.cpp 05c739e
> threadweaver/Examples/QProcessJob/MainWindow.cpp 8f70171
> threadweaver/Examples/SMIV/SMIV.cpp 41ac2d0
> threadweaver/Examples/SMIV/SMIVItem.cpp af252ba
> threadweaver/Tests/DeleteTest.cpp 112fe25
> threadweaver/Tests/JobTests.cpp 6f0b38a
> threadweaver/Tests/QueueTests.cpp f46c534
> threadweaver/Weaver/Job.cpp 6076d22
> threadweaver/Weaver/Thread.cpp 5bcdd26
> threadweaver/Weaver/ThreadWeaver.cpp 121bec1
> threadweaver/Weaver/WeaverImpl.cpp a8dc600
> threadweaver/WeaverGui/WeaverThreadGrid.cpp f0622d0
>
> Diff: http://git.reviewboard.kde.org/r/103728/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120213/250b9199/attachment.htm>
More information about the kde-core-devel
mailing list