Review Request: Fix the KApplication '--config' option

Cristian Oneț onet.cristian at gmail.com
Mon Feb 13 11:49:44 GMT 2012



> On Feb. 13, 2012, 11:41 a.m., David Faure wrote:
> > Ship It!

I would prefer that a developer that currently works on kdelibs made the commit since I'm not familiar with the kdelibs development process so I would not know in which branch to push this.

Thanks.


- Cristian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103693/#review10591
-----------------------------------------------------------


On Jan. 14, 2012, 9:27 a.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103693/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2012, 9:27 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch is a simple fix for the problem described in the bug report although I would not argue that it is the acceptable solution.
> But it highlights the cause of the bug - the fact that the shared config is created before the config name is set by setting the window icon.
> 
> 
> This addresses bug 291497.
>     http://bugs.kde.org/show_bug.cgi?id=291497
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kapplication.cpp cc20f05 
> 
> Diff: http://git.reviewboard.kde.org/r/103693/diff/
> 
> 
> Testing
> -------
> 
> Ran KMyMoney with the patched kdelibs and the '--config' option works as expected.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120213/79f89399/attachment.htm>


More information about the kde-core-devel mailing list