Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

Albert Astals Cid tsdgeos at
Thu Feb 9 23:28:13 GMT 2012

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 9, 2012, 11:28 p.m.)

Review request for kdelibs, Eike Hein, Christoph Feck, and Jeremy Paul Whiting.

------- broke subclasses of QComboBox that have a USER property like KColorCombo, this patch reverts this change and introduces a different code path to ignore the USER property of QComboBox and KComboBox and make it use our custom code.

This addresses bug 293702.

Diffs (updated)

  kdeui/tests/CMakeLists.txt 63788f6 
  kdeui/tests/kconfigdialog_unittest.cpp PRE-CREATION 
  kdeui/dialogs/kconfigdialogmanager.cpp 0890c0b 



Ran the attached test, everything worked.

Without moving the
 userproperty = getUserProperty(w);
the KColorCombo fails

Without adding the 
 s_propertyMap->insert( "KComboBox", "" );
the editable KComboBox fails


Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list