Review Request: Allow protocol-specialized ThumbCreators to be used for folder previews

[Sebastian Trueg]

> On Feb. 8, 2012, 8:43 p.m., David Faure wrote:
> > I don't understand, why didn't m_remoteProtocolPlugins do the job?

Because it does not include the services, only the supported protocols and mimetypes. We could merge the two - sure. I just wanted to change as little code as possible to avoid regressions.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103882/#review10429
-----------------------------------------------------------


On Feb. 8, 2012, 9:56 p.m., Sebastian Trueg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103882/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2012, 9:56 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The problem is fairly simple: I needed to create previews for directory items in a custom KIO slave. Writing the ThumbCreator was simple. But it got never called. The reason is that the thumbnail kio slave always uses its own directory thumbnailing method for folders if the plugin name is not specified in the metadata. The PreviewJob on the other hand does only specify the "plugin" metadata field for "local" ThumbCreators; remote ThumbCreators are only checked for existance.
> This patch fixes that by first checking for a specialized ThumbCreator plugin by protocol and then falling back to the old way of detection my mime-type.
> 
> 
> Diffs
> -----
> 
>   kio/kio/previewjob.cpp 5635875 
> 
> Diff: http://git.reviewboard.kde.org/r/103882/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on my custom KIO slave: perfect thumbnails. Thumbnails for everything else still working fine.
> 
> 
> Thanks,
> 
> Sebastian Trueg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120208/752db93f/attachment.htm>