Review Request: port Sonnet to QSettings

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107791/
-----------------------------------------------------------

(Updated Dec. 27, 2012, 12:52 a.m.)


Review request for KDE Frameworks, kdelibs and David Faure.


Changes
-------

Don't expose QSettings at all (now just in the internal, non-public Settings class).


Description
-------

Ported everything away from KConfig to QSettings.

I couldn't really find any users of the ::save function, so I think the source incompatible change would be worth it. Alternatively we could add a deprecated dummy function that takes in a KConfig object and just ignores it, and uses QSettings.


Diffs (updated)
-----

  kdeui/sonnet/configdialog.h 7c4993b 
  kdeui/sonnet/configdialog.cpp 625441b 
  kdeui/sonnet/configwidget.h 023b659 
  kdeui/sonnet/configwidget.cpp 549d5af 
  kdeui/sonnet/highlighter.cpp 6cbb14c 
  kdeui/sonnet/tests/test_configdialog.cpp 4c4fd21 
  kdeui/widgets/ktextedit.h d0c1c4d 
  kdeui/widgets/ktextedit.cpp 71d2a9f 
  staging/sonnet/src/core/backgroundchecker.h f0da3a3 
  staging/sonnet/src/core/backgroundchecker.cpp dc05b94 
  staging/sonnet/src/core/globals.cpp bf4f504 
  staging/sonnet/src/core/loader.cpp 887aee5 
  staging/sonnet/src/core/settings.cpp 59cb593 
  staging/sonnet/src/core/settings_p.h e14bad7 
  staging/sonnet/src/core/speller.h 37dd82f 
  staging/sonnet/src/core/speller.cpp f831f55 

Diff: http://git.reviewboard.kde.org/r/107791/diff/


Testing
-------

it builds.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121227/f71d61a6/attachment.htm>