Re: plasma and new shadow mess

[Thomas Lübking]

On Montag, 24. Dezember 2012 23:12:22 CEST, Weng Xuetian wrote:
> Hi Plasma world,
> As new shadow lands in KDE 4.10 RC1, some unintentional mess is introduced.
>
> https://bugs.kde.org/show_bug.cgi?id=311502
> https://bugs.kde.org/show_bug.cgi?id=311995

I doubt those have much relation, notably #311995 is not about shadows at all, but invocation of the non-ARGB theme under certain conditions.

> The problem is, custom widget using plasma svg doesn't get new shadow
> support automatically, some code must be written.

The problem of #311502 rather seems to be an insufficient repaint area - more related to bug #312168, i'd say.

Wild guess from your patch: don't remove the shadows before, but *after* the hiding (eventually "later", ie. in the deconstructor or on the destroyed signal) to avoid confusations between the deleted window size and the "dirty" area.

Cheers,
Thomas