Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

[Erwan MATHIEU]

> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote:
> > plasma/generic/wallpapers/image/image.cpp, lines 752-756
> > <http://git.reviewboard.kde.org/r/107821/diff/1/?file=100482#file100482line752>
> >
> >     Did I overlook something or where is the non-randomized wallpaper change now happening?
> 
> Erwan MATHIEU wrote:
>     Actually, the m_randomize variable was initialized to true in the constructor, and there was absolutely no way you could set it to false, so I dropped it. Maybe I shouldn't have... ?
> 
> Kai Uwe Broulik wrote:
>     Okay, right, I thought there was an checkbox in the background dialog but there isn't, so looks fine, except can you check how the "Next Wallpaper" context menu entry still works without it?

Well, it works as it always did : a random image is displayed next...


- Erwan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107821/#review23787
-----------------------------------------------------------


On Dec. 21, 2012, 5:11 p.m., Erwan MATHIEU wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107821/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 5:11 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Patch which corrects bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder
> 
> 
> This addresses bug 235710.
>     http://bugs.kde.org/show_bug.cgi?id=235710
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/image/backgroundlistmodel.h a289f49 
>   plasma/generic/wallpapers/image/backgroundlistmodel.cpp f5a4dce 
>   plasma/generic/wallpapers/image/image.h 417f5a7 
>   plasma/generic/wallpapers/image/image.cpp 006a748 
> 
> Diff: http://git.reviewboard.kde.org/r/107821/diff/
> 
> 
> Testing
> -------
> 
> Many pictures in many folders with many subfolders, adding and removing files (sometimes no more files available)
> 
> 
> Thanks,
> 
> Erwan MATHIEU
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121221/d4b03c27/attachment.htm>