Review Request: port sonnet away from i18nc
David Faure
faure at kde.org
Tue Dec 18 15:05:50 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107412/#review23680
-----------------------------------------------------------
According to the trojita discussion on kde-core-devel, we don't need the QCoreApplication::translate("", "foo") ugliness, a simple tr("foo") can do the job just fine. We'll need to adjust the existing code and the wiki, obviously.
- David Faure
On Dec. 17, 2012, 8:05 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107412/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2012, 8:05 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> port sonnet away from i18nc.
>
>
> Diffs
> -----
>
> staging/sonnet/src/core/loader.cpp 887aee5
> staging/sonnet/src/core/settings.cpp 59cb593
> staging/sonnet/src/core/speller.cpp f831f55
>
> Diff: http://git.reviewboard.kde.org/r/107412/diff/
>
>
> Testing
> -------
>
> it builds.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121218/407a40c2/attachment.htm>
More information about the kde-core-devel
mailing list