Review Request: Fix generating kconfig skeletons with UrlList fields that have a default value

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Dec 14 13:17:34 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107716/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

This patch changes the generated code so that if a property is "UrlList" in the kcfg file, the variable that will receive it when generating the skeleton is a KUrl::List instead a QStringList. This solves the following compiling error:

aleix at kubuntu:~/projects/muon/build$ make
[  0%] Built target muonprivate_automoc
[  0%] Building CXX object libmuon/CMakeFiles/muonprivate.dir/MuonDataSources.o
In file included from /usr/include/kcoreconfigskeleton.h:28:0,
                 from /usr/include/kconfigskeleton.h:28,
                 from /home/aleix/projects/muon/build/libmuon/MuonDataSources.h:8,
                 from /home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:4:
/usr/include/kurl.h: In constructor ‘MuonDataSources::MuonDataSources()’:
/usr/include/kurl.h:1146:3: error: ‘KUrl::operator QString() const’ is private
/home/aleix/projects/muon/build/libmuon/MuonDataSources.cpp:38:105: error: within this context


Diffs
-----

  kdecore/kconfig_compiler/kconfig_compiler.cpp 4203d30 

Diff: http://git.reviewboard.kde.org/r/107716/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121214/52b53602/attachment.htm>


More information about the kde-core-devel mailing list