Review Request: Fix mixed sentences in sftp error message

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107700/#review23446
-----------------------------------------------------------

Ship it!


Looks good to me.

- Dawit Alemayehu


On Dec. 13, 2012, 1:57 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107700/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 1:57 p.m.)
> 
> 
> Review request for KDE Runtime and Dawit Alemayehu.
> 
> 
> Description
> -------
> 
> When sftp fails because the host key of the server has changed, it emits KIO::ERR_CONNECTION_BROKEN with a translated error message as error text. This is wrong because KIO::ERR_CONNECTION_BROKEN expect the error text to be the hostname. Attached patch fixes the call to use KIO::ERR_SLAVE_DEFINED instead. See bug report for screenshots.
> 
> 
> This addresses bug 310645.
>     http://bugs.kde.org/show_bug.cgi?id=310645
> 
> 
> Diffs
> -----
> 
>   kioslave/sftp/kio_sftp.cpp 09a98f8 
> 
> Diff: http://git.reviewboard.kde.org/r/107700/diff/
> 
> 
> Testing
> -------
> 
> Tested with Gwenview, which failed to log on sftp://localhost (now I need to figure out why :) )
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121214/8a8be3da/attachment.htm>