Review Request: Keep clickmessage text visible when empty and focused

Aurélien Gâteau agateau at kde.org
Wed Dec 12 17:10:13 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107678/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

This patch changes the way KLineEdit and KTextEdit handle the clickMessage property. The message remains visible when the widget is focused, as long as no text has been typed in. This is useful when the widget is focused by default, and also gives another opportunity to the user to read the message before typing, removing the need for workarounds  like clicking in another text entry to bring back the clickMessage.

I filed a similar review-request for Plasma components: https://git.reviewboard.kde.org/r/107600/


Diffs
-----

  kdeui/widgets/klineedit.cpp d96c1c4 
  kdeui/widgets/ktextedit.cpp dfaf5b8 

Diff: http://git.reviewboard.kde.org/r/107678/diff/


Testing
-------

Tested KLineEdit in Dolphin "add place" dialog and KDevelop. Tested KTextEdit with Gwenview "description" image field.


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20121212/dde9aa52/attachment.htm>


More information about the kde-core-devel mailing list