Review Request: Remove redundant SSL certificate hostname mismatch check in KIO::TCPSlaveBase

Laszlo Papp lpapp at kde.org
Wed Aug 29 17:14:01 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105976/#review18258
-----------------------------------------------------------


Where can I see the diff?

- Laszlo Papp


On Aug. 28, 2012, 11:35 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105976/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2012, 11:35 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> The attached patch removes the code that performs SSL certificate host name mismatch check in TCPSlaveBase. Since we do not connect to servers using IP address anymore, it is simply redundant to perform checks that are already done in Qt's SSL classes.
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/105976/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120829/6c0dc8c7/attachment.htm>


More information about the kde-core-devel mailing list