Review Request: Mutex cleanup in KSharedDataCache

[Vadim Zhukov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106221/
-----------------------------------------------------------

(Updated Aug. 27, 2012, 8:50 a.m.)


Review request for kdelibs and Michael Pyne.


Changes
-------

Added error text printing, as requested by mpyne at .
Please note: strerror() is not thread-safe, so we have to use strerror_r(), which doesn't exists everywhere. So I've added another CMake check, and if it fails, still print error code directly.


Description
-------

- Remove "support" for thread-shared-only locks: they do not help at all but makes app crash instead of slowly work; lack of decent locks to be resolved later.
- Add error checking with console printouts.
- Consistently use "::" before global functions.

Probably failed mutexes should be destroyed in case of some errors, any thoughts?


This addresses bug 305023.
    http://bugs.kde.org/show_bug.cgi?id=305023


Diffs (updated)
-----

  kdecore/util/ConfigureChecks.cmake fe9f47e 
  kdecore/util/config-util.h.cmake 83ccdf7 
  kdecore/util/kshareddatacache.cpp 393902e 
  kdecore/util/kshareddatacache_p.h ec5a7a0 

Diff: http://git.reviewboard.kde.org/r/106221/diff/


Testing
-------

On OpenBSD-CURRENT.


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120827/159bf3ce/attachment.htm>