Review Request: konqueror: strip new line character from URL on paste automatically

David Faure faure at kde.org
Sat Aug 25 23:15:31 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106184/#review18003
-----------------------------------------------------------

Ship it!


Looks good. I'm not sure where the need for ParagraphSeparator and LineSeparator comes from though, do websites actually use that?

- David Faure


On Aug. 25, 2012, 7:56 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106184/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 7:56 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> This patch removes line-breaking chars when an URL is entered.
> Very handy if you paste URLs from e.g. an email which shows the complete URL broken into multiple lines.
> 
> 
> This addresses bug 159002.
>     http://bugs.kde.org/show_bug.cgi?id=159002
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqcombo.h 5c86fcd 
>   konqueror/src/konqcombo.cpp 8169aec 
> 
> Diff: http://git.reviewboard.kde.org/r/106184/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120825/92260d52/attachment.htm>


More information about the kde-core-devel mailing list