Review Request: Focus goes to location bar when opening link in new tab in foreground

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105984/
-----------------------------------------------------------

(Updated Aug. 25, 2012, 7:41 p.m.)


Review request for KDE Base Apps and David Faure.


Changes
-------

Moved the focus change test to KonqView::setLoading.


Description
-------

The attached patch address the bug reported in #304933. Right now if Konqueror is configured to open new tabs in the foreground, i.e. the "Open tabs in the background" option is unchecked, then the keyboard focus is put on the location bar instead of the view.


This addresses bugs 304865 and 304933.
    http://bugs.kde.org/show_bug.cgi?id=304865
    http://bugs.kde.org/show_bug.cgi?id=304933


Diffs (updated)
-----

  konqueror/src/konqframe.cpp 10ed7cd 
  konqueror/src/konqview.cpp db9ffd4 
  konqueror/src/konqviewmanager.cpp 5352eeb 

Diff: http://git.reviewboard.kde.org/r/105984/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120825/e8477ec4/attachment.htm>