Review Request: Focus goes to location bar when opening link in new tab in foreground

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105984/#review17743
-----------------------------------------------------------


Thanks for looking into this.

To be honest, I don't like the timer. It penalizes fast users, and it feels like a workaround. Surely at some point konqueror knows whether it's going to open a url in the tab or not. That's the point in the code where we should decide where to put the focus (and in terms of timing, this should happen almost immediately; we don't need to wait for a KonqRun or anything).

- David Faure


On Aug. 20, 2012, 2:22 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105984/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2012, 2:22 a.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch address the bug reported in #304933. Right now if Konqueror is configured to open new tabs in the foreground, i.e. the "Open tabs in the background" option is unchecked, then the keyboard focus is put on the location bar instead of the view.
> 
> 
> This addresses bugs 304865 and 304933.
>     http://bugs.kde.org/show_bug.cgi?id=304865
>     http://bugs.kde.org/show_bug.cgi?id=304933
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqframe.h 60aa4d0 
>   konqueror/src/konqframe.cpp 10ed7cd 
>   konqueror/src/konqviewmanager.cpp 5352eeb 
> 
> Diff: http://git.reviewboard.kde.org/r/105984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120820/ab3f2ce4/attachment.htm>