Review Request: Silence debug output in KBzip2Filter::uncompress

[Milian Wolff]

> On Aug. 16, 2012, 10:20 p.m., Michael Pyne wrote:
> > I like it, and it's even easier than what my fix was going to be.

OK to push it to KDE/4.9 and KDE/4.10 - or only the latter? or only master?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106056/#review17566
-----------------------------------------------------------


On Aug. 16, 2012, 6:16 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106056/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 6:16 p.m.)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> Only output warning message if the return value of bzDecompress is negative, which represents an error.
> 
> See e.g. bzlib.h:
> 
> #define BZ_OK                0
> #define BZ_RUN_OK            1
> #define BZ_FLUSH_OK          2
> #define BZ_FINISH_OK         3
> #define BZ_STREAM_END        4
> #define BZ_SEQUENCE_ERROR    (-1)
> #define BZ_PARAM_ERROR       (-2)
> #define BZ_MEM_ERROR         (-3)
> #define BZ_DATA_ERROR        (-4)
> #define BZ_DATA_ERROR_MAGIC  (-5)
> #define BZ_IO_ERROR          (-6)
> #define BZ_UNEXPECTED_EOF    (-7)
> #define BZ_OUTBUFF_FULL      (-8)
> #define BZ_CONFIG_ERROR      (-9)
> 
> As such, all negative values (or anything below BZ_OK) represents an error. Without this patch, using
> the KBzip2Filter would always spam the console with the following debug messages:
> 
> bzDecompress returned 4
> KBzip2Filter::uncompress 1
> 
> 
> Diffs
> -----
> 
>   kdecore/compression/kbzip2filter.cpp 0f55334 
> 
> Diff: http://git.reviewboard.kde.org/r/106056/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120816/f9333361/attachment.htm>