Review Request: Show warning when CopyJob fails to list a subdir

[Ambroz Bizjak]

> On Aug. 16, 2012, 1:10 p.m., Frank Reininghaus wrote:
> > kdeui/jobs/kdialogjobuidelegate.cpp, line 92
> > <http://git.reviewboard.kde.org/r/106052/diff/1/?file=78076#file78076line92>
> >
> >     I'm afraid the users suffering from https://bugs.kde.org/show_bug.cgi?id=206500 will kill us if they get a message box for every single file. Right now, they have the option to wait until the operation is completed, then close the first (and only) message box and be happy.

How about aggregating all the errors/warnings in a single dialog box as a list? E.g. the list would have fields like "message" and "file", and would allow the user to easily see all that went wrong and what files were involved. He could then select multiple entries and perform the same action on them, if applicable. E.g. if the message was "destination already exists, replace or skip?" he could select some of the entries and perform "ignore", but perform "replace" on others. The copying could continue in the background, and the replacements would be performed only once the user confirms then.


- Ambroz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106052/#review17531
-----------------------------------------------------------


On Aug. 16, 2012, 12:18 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106052/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2012, 12:18 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Display a warning when CopyJob fails to enter a subdirectory and thus can't copy it's content.
> 
> 
> Diffs
> -----
> 
>   kdeui/jobs/kdialogjobuidelegate.cpp fe48f87 
>   kio/kio/copyjob.h eb88c7a 
>   kio/kio/copyjob.cpp 8dde763 
>   kio/kio/job.cpp a7e1baf 
>   kio/kio/jobclasses.h de27f40 
> 
> Diff: http://git.reviewboard.kde.org/r/106052/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120816/5c006b9d/attachment.htm>