Review Request: avoid duplicate entries in konqueror address completion list

Mark Gaiser markg85 at gmail.com
Wed Aug 15 20:05:11 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106046/#review17474
-----------------------------------------------------------


I don't know the konqueror code, but i don't think this is the right way to do it. Imho it shouldn't even be inserted in the first place. Though someone else would have to confirm.

- Mark Gaiser


On Aug. 15, 2012, 5:24 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106046/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2012, 5:24 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> When opening e.g. "man:mdoc.samples" as URL in konqueror, the next time I type "man:mdoc" konqueror shows "man:mdoc, man:mdoc.samples, man:mdoc.samples" in the completion box (history list is added to completion list giving duplicates)
> This patch simply avoids having duplicates in that list.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.cpp c5468f9 
> 
> Diff: http://git.reviewboard.kde.org/r/106046/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120815/6374381d/attachment.htm>


More information about the kde-core-devel mailing list