Review Request: Fix hang in kcm_useraccount

[Michael Palimaka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105895/
-----------------------------------------------------------

(Updated Aug. 14, 2012, 12:33 p.m.)


Review request for KDE Base Apps.


Changes
-------

Updated review diff with Oswald's work, with a further change so that the password is only asked for if required.


Description
-------

When changing the user's full name, chfn may not necessarily produce any output. Since readLine blocks, the kcm may hang.

This change checks if chfn exited without output, and if so, use that exit status.


This addresses bug 156396.
    http://bugs.kde.org/show_bug.cgi?id=156396


Diffs (updated)
-----

  kdepasswd/kcm/chfnprocess.h c9f0700f51d0a749b43c75840c43b46ccadb538a 
  kdepasswd/kcm/chfnprocess.cpp 9f75d4aa75b41acec84e7798c789d4226ca3fab9 
  kdepasswd/kcm/main.cpp 5a5248e545cc75433024ae0464ac9f3e05b71900 

Diff: http://git.reviewboard.kde.org/r/105895/diff/


Testing (updated)
-------

Tested all combinations of password required and name change permitted, with success.


Thanks,

Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120814/2ee41d66/attachment.htm>