Review Request: kjs: Implement JSON.stringify

[Bernd Buschinski]

> On Aug. 12, 2012, 3:42 p.m., Maks Orlovich wrote:
> > kjs/jsonstringify.cpp, line 102
> > <http://git.reviewboard.kde.org/r/105057/diff/5/?file=74786#file74786line102>
> >
> >     Resetting m_state, m_rootIsUndefined here might be a good defensive move (just in case stringify starts getting called twice)

no, I can't reset m_state here, it might already be Failed* because of the values given in the ctor


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105057/#review17275
-----------------------------------------------------------


On July 25, 2012, 2:54 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105057/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 2:54 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> kjs: Implement JSON.stringify
> 
> patch needs https://git.reviewboard.kde.org/r/105056/ (JSON.parse)
> 
> 
> Diffs
> -----
> 
>   kjs/CMakeLists.txt 1188064 
>   kjs/CommonIdentifiers.h 8ee40e8 
>   kjs/json_object.h PRE-CREATION 
>   kjs/json_object.cpp PRE-CREATION 
>   kjs/jsonstringify.h PRE-CREATION 
>   kjs/jsonstringify.cpp PRE-CREATION 
>   kjs/ustring.h 49370ef 
> 
> Diff: http://git.reviewboard.kde.org/r/105057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120813/a37e5ac8/attachment.htm>